Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First couple of unit tests for the React engine #774

Merged
merged 1 commit into from
Jan 16, 2018
Merged

First couple of unit tests for the React engine #774

merged 1 commit into from
Jan 16, 2018

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Jan 16, 2018

Involves #536.

Summary of changes:
This adds the first couple of unit tests for the React engine. Currently requires the async-rendering branch of patternengine-node-react.

@geoffp geoffp requested a review from bmuenzenmeyer January 16, 2018 05:56
@coveralls
Copy link

coveralls commented Jan 16, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 72.176% when pulling 19cc5c8 on react-engine-unit-tests into 5342213 on dev.

bmuenzenmeyer
bmuenzenmeyer approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
🌔
🌃
🚀
🌃
💥
🕐 3...2...1...

@bmuenzenmeyer bmuenzenmeyer merged commit 1ed75af into dev Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffp @coveralls @bmuenzenmeyer