chore(charts): refactor how skeleton theme is applied

[dlabrecq]

Refactored the skeleton theme to use a cleaner implementation in chart-theme.ts and chart-theme-types.ts. This ensures our custom component props (e.g., label, etc.) are not passed to Victory charts, avoiding potential type errors.

For Victory props and our custom components, there are...

• Two base themes; BaseTheme and BaseComponentTheme.
• Two color themes; ColorTheme and ColorComponentTheme
• Two skeleton themes; one for Victory props, one for our custom components.

As before, the color theme is applied by merging base themes with either a skeleton or color theme (e.g., blue color theme props). If a custom component is being rendered (e.g., donut, bullet, etc.), component theme props are also merged with the base theme.

Skeleton label props are now applied separately, via a component theme, so the theme object provided to Victory charts only contains supported properties.

Closes #10346

[patternfly-build]

Preview: https://patternfly-react-pr-10348.surge.sh

A11y report: https://patternfly-react-pr-10348-a11y.surge.sh

[nicolethoen]

It's unexpected to me that type of each of these props is now VictoryThemeDefinition.

I guess it's because the types spread all the same props in this API doc.

So i guess that's not a comment that requires any action. just me documenting what I learned for maybe future me 😇

[dlabrecq]

This particular object may contain any of the theme props defined by VictoryThemeDefinition. For example, our custom donut utilization component overrides props for both Victory pie and legend. However, a custom component could override even more Victory theme props here (e.g., tooltip), if necessary.

[nicolethoen]

Lots of previously exported functions and objects were deleted - any concerns products will break as a result? Could these changes go into a v6 branch if so?

[dlabrecq]

Lots of previously exported functions and objects were deleted - any concerns products will break as a result? Could these changes go into a v6 branch if so?

These helpers are exported for use in our chart components. However, ChartThemeTypes and react-charts/src/components/ChartTheme/themes/components/* are not exported at the package level and have been marked @private.

All public APIs are defined at the package level via react-charts/src/components/index.ts, while other helpers are intended for internal use and not supported.

That said, I've marked as @deprecated and will remove them in the v6 branch.

[patternfly-build]

Your changes have been released in:

• @patternfly/[email protected]
• @patternfly/[email protected]

Thanks for your contribution! 🎉