Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 11 Shows both banners #35

Open
poorpaddy opened this issue Feb 20, 2018 · 4 comments
Open

iOS 11 Shows both banners #35

poorpaddy opened this issue Feb 20, 2018 · 4 comments

Comments

@poorpaddy
Copy link
Contributor

iOS shows both the native Safari smart banner and react-smartbanner. Not sure of the solution yet but an idea would be to remove the dependency of the meta tags.

@albertoperezf
Copy link

albertoperezf commented Mar 12, 2018

I check this using a real iOS 11 device (iPhone 7 Plus with iOS 11.2.6) and Safari and no problem at all (Already tested in local server & BrowserStack), the actual banner that shows up is the native one and the smartbanner is hidden.

whatsapp image 2018-03-12 at 2 02 24 pm

If you remove the meta tags from the project is probably that the smartbanner don't go at all. We have to wait for the main developer comments about this issue.

@patw0929
Copy link
Owner

Thanks for testing! @albertoperezf
I tested on iPad mini 2 (iOS 10.3.3) and it works fine too.

img_0164

@poorpaddy Could you provide more information about the situation?

@albertoperezf
Copy link

This issue is in fact duplicated (#23) and close after @patw0929 make a PR. Maybe @poorpaddy you could give us more info about you're dev environment (Device, iOS version) or how you are using the Smartbanner.

@poorpaddy
Copy link
Contributor Author

I've narrowed it down to it occuring when ignoring iOS version to always show custom smartbanner instead of iOS. I ended up just writing my own smartbanner because the meta and icon dependency is just too embedded into this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants