-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS native smart banner shows on top of this smart banner #23
Comments
I'm using iOS 10.3.3 & Safari, it seems ok, only the native smart banner shown up. |
I think the native smart banner should be disabled. Otherwise we will be seeing two banners, like below (using iPhone Safari): This issue has been reported here as well: kudago/smart-app-banner#60 |
I'm curious about the smartbanner (js) is shown automatically? Or it's shown by clicking the Related pr: #12 |
Yes this |
I made a PR #24, could you help me to review? Thanks! |
Safari has a built in feature that reads the same format meta tag and shows the smart banner. This causes the web to show two banners
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/PromotingAppswithAppBanners/PromotingAppswithAppBanners.html
The text was updated successfully, but these errors were encountered: