Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS native smart banner shows on top of this smart banner #23

Closed
imdongchen opened this issue Aug 15, 2017 · 5 comments
Closed

iOS native smart banner shows on top of this smart banner #23

imdongchen opened this issue Aug 15, 2017 · 5 comments

Comments

@imdongchen
Copy link

Safari has a built in feature that reads the same format meta tag and shows the smart banner. This causes the web to show two banners

https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/PromotingAppswithAppBanners/PromotingAppswithAppBanners.html

@patw0929
Copy link
Owner

I'm using iOS 10.3.3 & Safari, it seems ok, only the native smart banner shown up.
Could you provide more information about this issue? Thanks!

@imdongchen
Copy link
Author

I think the native smart banner should be disabled. Otherwise we will be seeing two banners, like below (using iPhone Safari):

img_6642 png

This issue has been reported here as well: kudago/smart-app-banner#60

@patw0929
Copy link
Owner

I'm curious about the smartbanner (js) is shown automatically? Or it's shown by clicking the iOS button? (force to change smartbanner type)


Related pr: #12

@imdongchen
Copy link
Author

Yes this react-smartbanner is shown by clicking the iOS button, and the native banner is shown automatically. I think when we want to show the react-smartbanner, the native banner should be disabled, right?

@patw0929
Copy link
Owner

I made a PR #24, could you help me to review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants