Commit google-services.json #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Apr 20, 2022
| ) | ||
| ) | ||
| Surface( | ||
| Surface(color = MaterialTheme.colors.background) { |
There was a problem hiding this comment.
This is a small unrelated UI change to make sure the time separator is opaque
martinbonnin
commented
Apr 20, 2022
|
|
||
| project.androidSetup() | ||
|
|
||
| project.extensions.findByName("android")!!.apply { | ||
| this as BaseExtension | ||
| defaultConfig.apply { | ||
| applicationId = "fr.paug.androidmakers" | ||
| namespace = "fr.paug.androidmakers" |
There was a problem hiding this comment.
I wanted to give a shot at the namespace thing, which took me down the rabbit hole of updating to the latest AS canary because Bumblebee doesn't find the application to start if package is not in the Manifest
. It's all working with Dolphin!
martinbonnin
commented
Apr 20, 2022
| @@ -1,13 +1,13 @@ | |||
| [versions] | |||
| kotlin = "1.6.10" | |||
| kotlin = "1.6.10" # bumping to 1.6.20 breaks IDE autocomplete | |||
There was a problem hiding this comment.
BoD
approved these changes
Apr 20, 2022
oldergod
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to contribute to the project by adding the firebase API keys. This is ok because the keys are in the APK anyways so there's no absolute way to secure them. They are just a bit more visible now. Also the keys are restricted for the
fr.paug.androidmakerspackageIds and the debug/release SHA1s.Because I use the
namespaceAPI from the AGP, the project now requires Android Studio Dolphin to be able to start the activities from the IDE