Use CredentialManager for Google Sign-In #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
approved these changes
Apr 29, 2024
# Conflicts: # androidApp/src/main/java/fr/paug/androidmakers/MainActivity.kt # gradle/libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoogleSignInfrom play-services-auth is deprecated. This replaces it with theCredentialManagerAPI from the Jetpack Credentials library configured with GoogleId to retrieve the Google Id token supplied to Firebase.The entire sign-in (and sign-out) process runs inside a single coroutine. There is no need to switch to another dispatcher because all the code is asynchronous and main-safe.
A different sign-in dialog is shown to the user but the functionality remains the same.
Note: the Wear app keeps using
GoogleSignInbecause no alternative exists for Wear yet and the Horologist authentication UI is based onGoogleSignIn.