Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to search an ip with in a subnet #12

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

tlitovsk
Copy link

When having multiple subnets with the same ip range this will return the address in the given subnet.
That subnet may not talk to each other but still exist under one phpIPAM instance, especially on ones migrated from previous versions or with ping autodetect that does not write to the right subnet
This pull request is needed to help terraform providers handle those older migrated phpIPAM and other less standard cases.
It will be used when the free address was reserved but in search gets multiple results from different subnets when in fact we know the exact subnet used.

When having multiple subnets with same ip range this will return the address in the given subnet. Those subnet may not talk to each other, but still exist under one phpIPAM instance especially on ones migrated from previous versions
@tlitovsk
Copy link
Author

tlitovsk commented Apr 3, 2023

@pavel-z1 hi, I am having a project with duplicate IP's in a very long-live phpIPAM DB. This will really help us to use terraform there. ( I will use this function in the terraform provider )

@pavel-z1 pavel-z1 merged commit a93e9ab into pavel-z1:master Apr 4, 2023
@pavel-z1
Copy link
Owner

pavel-z1 commented Apr 4, 2023

Hi @tlitovsk , thank you
Merged this PR to master

@tlitovsk
Copy link
Author

tlitovsk commented Apr 4, 2023

@pavel-z1 Thank you heaps.
can you please make a new release so my pull request for the terraform provider is able to use the new code? lord-kyron/terraform-provider-phpipam#61

@pavel-z1
Copy link
Owner

pavel-z1 commented Apr 6, 2023

@tlitovsk We have several pull requests for review
After these PRs I will create new release.
I plan to do it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants