[BUG] Download.bittorrent is never None

[lzzy12]

When I try to download something with HTTP (not torrent), I expect the Download.bittorrent to be None however this is never the case.
Here is Download._struct for https://speed.hetzner.de/100MB.bin

{'completedLength': '0', 'connections': '1', 'dir': '/home/shivam/downloads//816/', 'downloadSpeed': '0', 'files': [{'completedLength': '0', 'index': '1', 'length': '0', 'path': '', 'selected': 'true', 'uris': [{'status': 'used', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}, {'status': 'waiting', 'uri': 'https://speed.hetzner.de/100MB.bin'}]}], 'gid': 'be0fa29b8fbc0c96', 'numPieces': '0', 'pieceLength': '1048576', 'status': 'active', 'totalLength': '0', 'uploadLength': '0', 'uploadSpeed': '0'}

While here is the Download._struct when a torrent is added:

{'bittorrent': {'announceList': [['http://nyaa.tracker.wf:7777/announce'], ['udp://open.stealth.si:80/announce'], ['udp://tracker.opentrackr.org:1337/announce'], ['udp://tracker.coppersurfer.tk:6969/announce'], ['udp://exodus.desync.com:6969/announce']]}, 'completedLength': '0', 'connections': '0', 'dir': '/home/shivam/downloads//817/', 'downloadSpeed': '0', 'files': [{'completedLength': '0', 'index': '1', 'length': '0', 'path': '[METADATA][Anime Time] Princess Connect! ReDive - 1 [720p].mp4', 'selected': 'true', 'uris': []}], 'gid': 'df71125cecd63d13', 'infoHash': '985e7f658509dca05b6b1560a4213950b11b7373', 'numPieces': '0', 'numSeeders': '0', 'pieceLength': '16384', 'seeder': 'false', 'status': 'active', 'totalLength': '0', 'uploadLength': '0', 'uploadSpeed': '0'}

[pawamoy]

Thank you for the report @lzzy12!

I will add a is_torrent method that checks if the bittorrent key is in self._struct.

Additionally we could make the bittorrent property return None instead of an "empty" BitTorrent instance, what do you think?

[lzzy12]

Additionally we could make the bittorrent property return None instead of an "empty" BitTorrent instance, what do you think?

Yeah that would make more sense

[pawamoy]

Implemented in v0.9.0. download.bittorrent will now return None if the "bittorrent" key is not in the _struct dictionary. This release also adds the download.is_torrent property.