Skip to content

Commit

Permalink
Auto merge of rust-lang#109458 - Nilstrieb:smol-cute-little-bits, r=w…
Browse files Browse the repository at this point in the history
…esleywiser

Use `SmallVec` in bitsets

This doesn't increase their size and means that we don't have to heap allocate for small sets.
  • Loading branch information
bors committed Mar 25, 2023
2 parents 96bd50d + 29c1132 commit 2d429f3
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions compiler/rustc_index/src/bit_set.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use crate::vec::{Idx, IndexVec};
use arrayvec::ArrayVec;
use smallvec::{smallvec, SmallVec};
use std::fmt;
use std::iter;
use std::marker::PhantomData;
Expand Down Expand Up @@ -111,7 +112,7 @@ macro_rules! bit_relations_inherent_impls {
#[derive(Eq, PartialEq, Hash, Decodable, Encodable)]
pub struct BitSet<T> {
domain_size: usize,
words: Vec<Word>,
words: SmallVec<[Word; 2]>,
marker: PhantomData<T>,
}

Expand All @@ -127,14 +128,15 @@ impl<T: Idx> BitSet<T> {
#[inline]
pub fn new_empty(domain_size: usize) -> BitSet<T> {
let num_words = num_words(domain_size);
BitSet { domain_size, words: vec![0; num_words], marker: PhantomData }
BitSet { domain_size, words: smallvec![0; num_words], marker: PhantomData }
}

/// Creates a new, filled bitset with a given `domain_size`.
#[inline]
pub fn new_filled(domain_size: usize) -> BitSet<T> {
let num_words = num_words(domain_size);
let mut result = BitSet { domain_size, words: vec![!0; num_words], marker: PhantomData };
let mut result =
BitSet { domain_size, words: smallvec![!0; num_words], marker: PhantomData };
result.clear_excess_bits();
result
}
Expand Down Expand Up @@ -1571,7 +1573,7 @@ impl<T: Idx> From<BitSet<T>> for GrowableBitSet<T> {
pub struct BitMatrix<R: Idx, C: Idx> {
num_rows: usize,
num_columns: usize,
words: Vec<Word>,
words: SmallVec<[Word; 2]>,
marker: PhantomData<(R, C)>,
}

Expand All @@ -1584,7 +1586,7 @@ impl<R: Idx, C: Idx> BitMatrix<R, C> {
BitMatrix {
num_rows,
num_columns,
words: vec![0; num_rows * words_per_row],
words: smallvec![0; num_rows * words_per_row],
marker: PhantomData,
}
}
Expand Down

0 comments on commit 2d429f3

Please sign in to comment.