FISH-8953 Fix Incorrect Unprocessed Change Showing for Hazelcast Encryption Settings #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changed Signed-off-by: Andrew Pielage <[email protected]>
kalinchan
approved these changes
Jul 5, 2024
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 13, 2024
FISH-8953 Fix Incorrect Unprocessed Change Showing for Hazelcast Encryption Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check that the Hazelcast encryption settings have actually changed before displaying "Restart Required".
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Started the admin console and went to the datagrid config page (Domain > Data Grid).
Set 'Restart Data Grid' to true (and change nothing else) and click 'Save' - "Restart Domain" should not be shown.
Enable 'Encrypt Data Grid' and click 'Save' again - "Restart Domain" should be shown (as well as some warnings saying you haven't configured it properly).
Testing Environment
Windows 11
Documentation
N/A
Notes for Reviewers
None