Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-8142 Update Mojarra #6905

Merged
merged 2 commits into from
Aug 29, 2024
Merged

FISH-8142 Update Mojarra #6905

merged 2 commits into from
Aug 29, 2024

Conversation

Viii3
Copy link
Member

@Viii3 Viii3 commented Aug 23, 2024

Description

  • Resolves FISH-8142

Important Info

Blockers

Testing

New tests

Testing Performed

Built the server and ran it against Faces TCK 4.0.3

Testing Environment

Maven version: 3.6.3
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "6.8.0-40-generic", arch: "amd64", family: "unix"

Documentation

Notes for Reviewers

Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Andrew Pielage <[email protected]>
@Viii3
Copy link
Member Author

Viii3 commented Aug 27, 2024

Kicked off a run here: https://jenkins.payara.fish/blue/organizations/jenkins/JakartaEE-10-TCK/detail/JakartaEE-10-TCK/253/pipeline/

The TCK succeeded but the run ultimately failed during the summary. Jenkins was looking for the non-existent 4.0.1 folder for the results. I've made a new PR to resolve this.

Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Viii3 Viii3 merged commit 2f7e3d9 into payara:main Aug 29, 2024
1 check passed
@Viii3 Viii3 deleted the FISH-8142-Update-Mojarra branch September 3, 2024 08:41
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants