-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: significantly reduce form-state response size by up to 2x #9388
Open
jacobsfletch
wants to merge
18
commits into
main
Choose a base branch
from
perf/optimize-form-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+256
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
perf: optimizes form state response by removing undefined and unnecessary properties
perf: significantly reduce form state response size
Nov 20, 2024
jacobsfletch
changed the title
perf: significantly reduce form state response size
perf: significantly reduce form-state response size by up to 2x
Nov 21, 2024
jacobsfletch
force-pushed
the
perf/optimize-form-state
branch
from
November 21, 2024 22:00
d98fe26
to
4c156ce
Compare
AlessioGr
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly optimizes the form-state response, reducing its size by up to more than 2x. This has rolling effects on initial page size as well, where the initial state for the entire form is sent through the request. To achieve this, we do the following:
$undefined
strings that are potentially attached to properties likevalue
,initialValue
,fieldSchema
, etc.errorPaths
arrays and emptycustomComponents
objects, which only need to exist if usedvalid
,passesCondition
, etc. which only need to be returned if explicitlyfalse
isSidebar
, which simply don't need to exist at all, as they can be easily calculated during renderFor backward compatibility, some of these changes are behind a temporary
experimental.optimized
flag.Results
The following results were gathered by booting up each test suite listed below using the existing seed data, navigating to a document in the relevant collection, then typing a single letter into the noted field in order to invoke new form-state. The result is then saved to the file system for comparison.
field-perf
blocks-collection
layout.0.field1
fields
array-fields
items.0.text
fields
block-fields
blocks.0.richText