Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide method to translate "Close" text #25

Closed
weboverhauls opened this issue Mar 10, 2014 · 3 comments
Closed

Provide method to translate "Close" text #25

weboverhauls opened this issue Mar 10, 2014 · 3 comments

Comments

@weboverhauls
Copy link
Collaborator

The close button is modified for accessibility which works great. Part of this fix is using the word "Close" instead of "×". To enhance for internationalization, suggest adding the option to use a variable or a data attribute to get the text "Close" (or its translated text).

$('.close').removeAttr('aria-hidden').wrapInner('<span aria-hidden="true"></span>').append('<span class="sr-only">Close</span>')
@weboverhauls
Copy link
Collaborator Author

Clarification: This is for the Alert. (There no i18n issue with the "close" text for other items such as Modal because the text is in the HTML.)

@cvrebert
Copy link
Contributor

I don't think this is an issue anymore thanks to twbs/bootstrap#13493 ?

@weboverhauls
Copy link
Collaborator Author

Hey, thanks for the PR. I did notice this improvement after I started digging into things, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants