Improve accessibility of close buttons in modals & alerts #13493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds textual caption to the close buttons. The "X" multiplication sign isn't very meaningful to screenreaders. Credit: https://github.com/paypal/bootstrap-accessibility-plugin Per: https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#alert https://github.com/paypal/bootstrap-accessibility-plugin/blob/master/README.md#modal-dialog
|
Should it be more specific? Like, "Close alert"? |
|
🤷 Plain "Close" was apparently good enough for the PayPal folks and avoids context sensitivity. But I'm willing to change it if you want. |
|
Nah this looks fine. Nice work <3. |
cvrebert
added a commit
that referenced
this pull request
May 4, 2014
Improve accessibility of close buttons in modals & alerts
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds textual caption to the close buttons. The "X" multiplication sign isn't very meaningful to screenreaders.
Per/Credit: https://github.com/paypal/bootstrap-accessibility-plugin
/cc @mdo for review