Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts migration #107

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

ts migration #107

wants to merge 46 commits into from

Conversation

xuanwan05
Copy link

No description provided.

@xuanwan05 xuanwan05 requested a review from a team as a code owner November 2, 2022 21:13
@xuanwan05 xuanwan05 marked this pull request as draft November 2, 2022 21:15
dtjones404
dtjones404 reviewed Nov 3, 2022
View reviewed changes
src/env.ts Outdated Show resolved Hide resolved
@xuanwan05 xuanwan05 marked this pull request as ready for review November 8, 2022 20:02
dtjones404
dtjones404 reviewed Nov 28, 2022
View reviewed changes
webpack.config.ts Outdated Show resolved Hide resolved
@dtjones404
Copy link
Contributor

There's a flow pragma and a FlowFixMe in index.ts that could be removed (I can't make a GitHub suggestion since the file wasn't modified)

@nbierdeman
PPoF - New FPTI Keys (#113)
c5004e4 
* Add FI_ID to FPTI_KEY

* Add CARD_BALANCE & BANK_BALANCE to WALLET_INSTRUMENT

* Revert 'Add CARD_BALANCE & BANK_BALANCE to WALLET_INSTRUMENT'

* Add PRODUCT to FPTI_KEY
@dtjones404
Copy link
Contributor

PR's looking good by the way! 🎉

sathyashyam2406 and others added 20 commits November 29, 2022 08:55
@sathyashyam2406
feat: Adding Paidy as New APM (#112)
f242896 
* feat: Adding Paidy into FUNDING

* feat: Adding Paidy into FundingEligibilityType

* feat: Adding Paidy as New APM

* feat: Removed the dist module file
@wsbrunson
Dist
5f87d89
@wsbrunson
1.0.128
046e801
@xuanwan05
feat!: ts-migration
c0a1906
@xuanwan05
simplify the code
b096a11
@xuanwan05
replace const with enum
1f3dd40
@xuanwan05
update package.json
22345f2
@xuanwan05
remove flow script
d5532b3
@xuanwan05
remove flow-script script from main.yml
86d9e1d
@xuanwan05
Revert "replace const with enum"
47f685f 
This reverts commit 9d5e402.
@xuanwan05
revert enum to const
558758c
@xuanwan05
feat!: ts-migration
f26c6e0
@xuanwan05
simplify the code
66db722
@xuanwan05
replace const with enum
3668271
@xuanwan05
update package.json
6677256
@xuanwan05
Revert "replace const with enum"
9d92174 
This reverts commit 9d5e402.
@xuanwan05
revert enum to const
d223385
@xuanwan05
Delete babel.config.json
f8554ff
@xuanwan05
resolve commit conflicts
4c1af2f
@xuanwan05
Merge branch 'ts-migration' of https://github.com/paypal/paypal-sdk-c…
561e5b5 
…onstants into ts-migration
dtjones404
dtjones404 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@dtjones404 dtjones404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

.eslintrc.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westeezy westeezy westeezy left review comments

@dtjones404 dtjones404 dtjones404 approved these changes

@wsbrunson wsbrunson wsbrunson approved these changes

@gregjopa gregjopa Awaiting requested review from gregjopa

@prashantjagasia prashantjagasia Awaiting requested review from prashantjagasia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xuanwan05 @dtjones404 @westeezy @wsbrunson @nbierdeman @sathyashyam2406