Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: destination_dir doesn't play nicely with cname/enable_jekyll #757

Open
3 tasks done
nex3 opened this issue May 26, 2022 · 1 comment
Open
3 tasks done

support: destination_dir doesn't play nicely with cname/enable_jekyll #757

nex3 opened this issue May 26, 2022 · 1 comment
Assignees
Labels
support User support

Comments

@nex3
Copy link

nex3 commented May 26, 2022

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your question

If you set destination_dir to a directory other than the default root-level directory (such as docs), the action will still put the CNAME and .no_jekyll files at the root of the repository, causing them to be ignored by GitHub pages when that sub-directory is set as the deployment root.

Relevant links

Public repository: https://github.com/sass/sass-site/tree/cd3443d2940b1925001e9627ed05c765247235ed
YAML config: https://github.com/sass/sass-site/blob/cd3443d2940b1925001e9627ed05c765247235ed/.github/workflows/ci.yml
YAML workflow: https://github.com/sass/sass-site/runs/6601995954

Relevant log output

No response

Additional context.

No response

@peaceiris
Copy link
Owner

What is your purpose in the setting destination_dir: docs? Why don't you deploy the root directory of the gh-pages branch? Deploying /docs is an old way.

nex3 added a commit to sass/sass-site that referenced this issue May 26, 2022
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support User support
Projects
None yet
Development

No branches or pull requests

2 participants