Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Exclude writing actions on forks #562

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Jan 21, 2021

This will let people who forked this repository run CI without seeing misleading failures.

This will let people who forked this repository run CI without seeing misleading failures.
@oprypin oprypin requested a review from peaceiris as a code owner January 21, 2021 01:45
@peaceiris peaceiris added the cicd label Jan 21, 2021
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #562 (80d746b) into main (87b7480) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   61.17%   61.17%           
=======================================
  Files           4        4           
  Lines         273      273           
  Branches       48       48           
=======================================
  Hits          167      167           
  Misses        105      105           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b7480...80d746b. Read the comment docs.

@oprypin oprypin changed the title patch 1 Limit CI write actions to the main repo, not forks Jan 21, 2021
@oprypin
Copy link
Contributor Author

oprypin commented Jan 21, 2021

(woops, sorry for the broken pull request title)

@peaceiris
Copy link
Owner

peaceiris commented Jan 21, 2021

Thank you for your contribution. 👍

I think the following is more general.

- github.repository_owner == 'peaceiris'
+ github.event.repository.fork == false

I will add my commit to do that.

@peaceiris peaceiris changed the title Limit CI write actions to the main repo, not forks ci: Exclude writing actions on forks Jan 21, 2021
@peaceiris peaceiris merged commit fcead0e into peaceiris:main Jan 21, 2021
peaceiris added a commit that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants