Check _temp_tarname before deleting temp file in destructor. #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a security hardening which I believe is safe to discuss in public.
The
__destruct()
method can be abused via deserialization / object injection to delete arbitrary files.As it looks like
_temp_tarname
is only ever set in one place:...it seems like we should be able to check the filename before actually deleting a "temp file".
Additional checking could be done to ensure that
_tarname
matches the above etc..., but just checking_temp_tarname
should be sufficient to avoid abuse.