-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added php72 #5
added php72 #5
Conversation
LGTM! ( I am not a maintainer of PEAR so I can't merge but LGTM ) I hope to review and merge somebody. |
@convissor @LawnGnome |
PR LGTM also. Not entirely sure why Travis-CI didn't run. Does it need to be enabled for this repo? |
@kokspflanze Can you add a commit? I think I enabled the repository on Travis-CI. |
@till added =) |
thats why 5.3 fail=(
|
@till I'll try to look at it this week. |
changed php5.3 to precise dist
removed php5.3 from default travis list
for php5.3 i added a matrix entry to use |
A new release with these changes would really be helpful, as Composer does not pull in transitive In other words, you cannot get rid of warnings on PHP 7.2 if pear/db is a transitive dependency. I am not sure about the PEAR release process and maintainership: Can you release/tag a new version here if it does not at the same time show up in pear.php.net? If you really care about leaving PHP 5.3 as a supported platform behind, tag 1.10.0 - you could then still release critical bug fixes for PHP 5.3 as 1.9.x. No need for a 2.0 release IMO, no breaking changes here. |
@mpdude released as v1.9.3. |
added php71 and php72 in travis.yml
fixed countable warnings