Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added php72 #5

Merged
merged 8 commits into from
Jul 20, 2018
Merged

added php72 #5

merged 8 commits into from
Jul 20, 2018

Conversation

kokspflanze
Copy link
Contributor

added php71 and php72 in travis.yml
fixed countable warnings

@hypermkt
Copy link

hypermkt commented Mar 3, 2018

LGTM! ( I am not a maintainer of PEAR so I can't merge but LGTM ) I hope to review and merge somebody.

@hypermkt
Copy link

hypermkt commented Mar 4, 2018

@convissor @LawnGnome
It's not my PR but I also hope to add PHP 7.1 and 7.2 to travis. so Could you review this PR?

@till
Copy link
Member

till commented Mar 11, 2018

PR LGTM also. Not entirely sure why Travis-CI didn't run. Does it need to be enabled for this repo?

@till
Copy link
Member

till commented Mar 11, 2018

@kokspflanze Can you add a commit? I think I enabled the repository on Travis-CI.

@kokspflanze
Copy link
Contributor Author

@till added =)

@kokspflanze
Copy link
Contributor Author

thats why 5.3 fail=(

PHP 5.3 is supported only on Precise.
See https://docs.travis-ci.com/user/reference/trusty#PHP-images on how to test PHP 5.3 on Precise.
Terminating.

@till
Copy link
Member

till commented Jun 10, 2018

@ashnazg @cweiske Can we do a PEAR-DB-2.0.0 release with these additions to show that we no longer support PHP 5.3? (Had this in my notifications for too long.)

@ashnazg
Copy link
Member

ashnazg commented Jun 10, 2018

@till I'll try to look at it this week.

changed php5.3 to precise dist
removed php5.3 from default travis list
@kokspflanze
Copy link
Contributor Author

for php5.3 i added a matrix entry to use precise as dist

@ashnazg ashnazg merged commit e6b1811 into pear:trunk Jul 20, 2018
@mpdude
Copy link

mpdude commented Dec 1, 2018

@ashnazg and @cweiske

A new release with these changes would really be helpful, as Composer does not pull in transitive dev dependencies unless you relax preferred stability constraints.

In other words, you cannot get rid of warnings on PHP 7.2 if pear/db is a transitive dependency.

I am not sure about the PEAR release process and maintainership: Can you release/tag a new version here if it does not at the same time show up in pear.php.net?

If you really care about leaving PHP 5.3 as a supported platform behind, tag 1.10.0 - you could then still release critical bug fixes for PHP 5.3 as 1.9.x.

No need for a 2.0 release IMO, no breaking changes here.

@ashnazg
Copy link
Member

ashnazg commented Dec 5, 2018

@mpdude released as v1.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants