ffff #27
Merged
ffff #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From "Exploit" to a random alphanumeric String in order to make it less fingerprintable. Co-authored-by: acammack-r7 <[email protected]>
…arbitrary file write
As of Jan 30, the latest version of get-pip provides pip 21.0+ and no longer supports python2 syntax. By pulling down the locked version directly from github instead of latest from pypi the requirement to only support python3 is deferred.
Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Thanks, I thought the comments on it would be needed/ (this is my first module) Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb [+] thanks! Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb [+] thanks for the sharp eye! It certainly does. I tried at my side to make it look as a "flow" but never really succeeded with it. Again, thanks! Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Co-authored-by: bcoles <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Of course, this is my first module - I'm sorry, thanks for pointing it out! Co-authored-by: Spencer McIntyre <[email protected]> Update fanny_bmp_check.rb Changed ...on #{sysinfo['Computer']} for... to "Target #{match} result(s) found in And as well as the + 'shell' in the session types. And, as well as commented some stuff I will remove (the comments, that is) when this is done. The URL (ref) at the Desc. of the module needs to be a bit more short. Will do this too. Changed (if not already?) the src link. Create fanny_bmp_check_Docs.md Rename fanny_bmp_check_Docs.md to fanny_bmp_check.md Docs ready to go, (msftidy_docs done[x]) ./tools/dev/msftidy_docs.rb documentation/modules/post/windows/gather/forensics/fanny_bmp_check.md (no results) - so It's ready to go msftidy.rb Done [no errors) msftidy.rb Done [no errors) Update fanny_bmp_check.md Update fanny_bmp_check.md Removed References since they were not (really) meant for being included, It was more of my own Notes/Comments that accidentally came with it. 👍 Indentation (2 spaces, + the 33 to 44 lineblock fixed[x]) Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Co-authored-by: bcoles <[email protected]> fanny_bmp_check.rb Updated fanny_bmp_check.rb to use arrays instead. Update fanny_bmp_check.rb Rubocop fixed Update fanny_bmp_check.rb Added report_vuln() as Jmartin suggested Update fanny_bmp_check.rb Update v2 Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Oh, yes - Thank you, again - sorry Co-authored-by: Jeffrey Martin <[email protected]> Sorry for confusion; 2 problems(line 66+line 61) (work arounded for now) 2 Problems, first; it did not work with the info line (line 66, 61) If It's still wrong ( the loop , which I have tried to fix) I am not entirely sue what the problem is, because If I had the end there it was (commented out, line 61) - then it gets, unexpected 'end' expecting end-of-input, Coming back again, sorry for the confusion. Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Ah, tried it over here - and it worked, Thanks! Co-authored-by: Jeffrey Martin <[email protected]> Update documentation/modules/post/windows/gather/forensics/fanny_bmp_check.md Of course, thanks, committing this suggestion. Regards Co-authored-by: Shelby Pace <[email protected]> Update modules/post/windows/gather/forensics/fanny_bmp_check.rb Co-authored-by: Shelby Pace <[email protected]>
Merge branch 'land-14564' into upstream-master
…auxiliary/scanner/ssh/ssh_enumusers
Merge branch 'land-14627' into upstream-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what this change does. If you're fixing a bug, please mention
the github issue number.
Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.
Verification
List the steps needed to make sure this thing works
msfconsoleuse exploit/windows/smb/ms08_067_netapiIf you are opening a PR for a new module that exploits a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us a demo of your module executing correctly. Seeing your module in action will help us review your PR faster!
Specific Hardware Examples:
Complex Software Examples:
We will also accept demonstrations of successful module execution even if your module doesn't meet the above conditions. It's not a necessity, but it may help us land your module faster!
Demonstration of successful module execution can take the form of a packet capture (pcap) or a screen recording. You can send pcaps and recordings to [email protected]. Please include a CVE number in the subject header (if applicable), and a link to your PR in the email body.