Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompting #87

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Prompting #87

merged 10 commits into from
Jun 28, 2024

Conversation

MischaPanch
Copy link
Collaborator

@MischaPanch MischaPanch commented Jun 25, 2024

  1. Separates refactoring of SVG from variation
  2. A whole bunch of "prompt engineering"
  3. Better names in ShapeCollection
  4. Fixed some issues (default behavior, names) with unique-id generations in SVG.to_string
  5. Added chrome to docker image. The docker image (and hence the codespace) now fully work

@MischaPanch MischaPanch requested a review from opcode81 June 25, 2024 21:17
@opcode81
Copy link
Collaborator

The diff display on GitHub is broken. Only 2 commits are not yet in branch main, but it's showing 10.

@MischaPanch
Copy link
Collaborator Author

@opcode81 actions also don't start. I'm gonna go ahead and merge this

@MischaPanch MischaPanch merged commit 5ecf086 into main Jun 28, 2024
@MischaPanch
Copy link
Collaborator Author

@opcode81 had to merge locally and push to develop since GH wouldn't let me do that through UI.

Interestingly, now it's shown as merged and the diff looks as it's supposed to. If you want, feel free to comment here and I'd address the comments directly on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants