Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cleanup on stopping agent #382

Merged
merged 5 commits into from
Oct 1, 2019
Merged

fix: Cleanup on stopping agent #382

merged 5 commits into from
Oct 1, 2019

Commits on Oct 1, 2019

  1. ♻️ Dry up start and exec commands 

    Both of these commands start and stop in the same way, and all
commands can benefit from handling termination events
    @wwilsman
    wwilsman committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    57dc2f8 View commit details
    Browse the repository at this point in the history

  2. fix: 🐛 Suppress error when a PID file does not exist

    @wwilsman
    wwilsman committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    56a505b View commit details
    Browse the repository at this point in the history

  3. fix: 🐛 Cleanup PID file when start command is terminated (#340) 

    When sigterm and friends are recieved, the server gets stopped but leaves behind
the PID file which causes future runs to think there is already a running
agent. With the recent adjustments to how termination events are handled, we can
safely cleanup that file in the stop method.
    @wwilsman
    wwilsman committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    9b17d04 View commit details
    Browse the repository at this point in the history

  4. fix: 🐛 Catch error from child process event and stop agent

    @wwilsman
    wwilsman committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    94a065f View commit details
    Browse the repository at this point in the history

  5. fix: 🐛 Add process handlers to static snapshot command

    @wwilsman
    wwilsman committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    1652650 View commit details
    Browse the repository at this point in the history