fix: Add rootResourceURL in front of percy specific resources #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
approved these changes
Oct 3, 2019
delete-merged-branch
bot
deleted the
rd/percy-specific-css-resource-url
branch
djones
pushed a commit
that referenced
this pull request
Oct 3, 2019
## [0.18.2](v0.18.1...v0.18.2) (2019-10-03) ### Bug Fixes * Add rootResourceURL in front of percy specific resources ([#388](#388)) ([ebc3594](ebc3594))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR adds the parsedRootResourceURL in front of the Percy specific CSS resource we create. This will fix issues we see when we're proxying HTTPS assets