Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't log success on error #435

Merged
merged 2 commits into from
Dec 11, 2019
Merged

fix: don't log success on error #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86edc6c
fix: Only log finalize success if it was actually successful
Robdel12 Dec 11, 2019
5e9f4e8
fix: log finalize error to stderr
wwilsman Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/services/build-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ export default class BuildService extends PercyClientService {
async finalize() {
if (!this.buildId) { return }

await this.percyClient.finalizeBuild(this.buildId).catch(logError)
this.logEvent('finalized')
try {
await this.percyClient.finalizeBuild(this.buildId)
this.logEvent('finalized')
} catch (err) {
logError(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some context here.. Perhaps a log line above this logError that says Error during build finalize: or something similar.

}
}

async finalizeAll(): Promise<any> {
Expand Down
10 changes: 10 additions & 0 deletions test/acceptance/exec.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,16 @@ describe('percy exec', () => {
expect(proxy.requests['/builds/123/finalize']).toHaveLength(1)
})

it('logs finalization errors', async () => {
proxy.mock('/builds/:id/finalize', () => [404, { success: false }])

let [stdout, stderr] = await run('percy exec -- echo test')

expect(stdout).toHaveEntry('[percy] created build #4: <<build-url>>')
expect(stderr).toHaveEntry('[percy] StatusCodeError 404 - {"success":false}')
expect(stdout).not.toHaveEntry('[percy] finalized build #4: <<build-url>>')
})

describe('with snapshots', () => {
let dummy = setupDummyApp()

Expand Down