Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(📦): Unpin puppeteer #522

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(📦): Unpin puppeteer #522

merged 1 commit into from
Jun 2, 2020

Conversation

wwilsman
Copy link
Contributor

@wwilsman wwilsman commented Jun 2, 2020

When Puppeteer 3.2 shipped breaking changes, 3.1 was pinned. 3.3 now rolls back those breaking changes so we can safely continue to use 3.x. It is likely that 4.x will re-introduce those breaking changes, but we can figure out a way forward from there (also when their API docs are updated with deprecations and alternatives to event emitter methods).

When 3.2 shipped breaking changes, 3.1 was pinned. 3.3 now rollsback those
breaking changes so we can safely continue to use 3.x. It is likely that 4.x
will re-introduce those breaking changes, but we can figure out a way forward
from there (also when their API docs are updated with deprecations and
alternatives to event emitter methods).
@wwilsman wwilsman requested a review from Robdel12 June 2, 2020 15:51
Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@wwilsman wwilsman merged commit e196d3d into master Jun 2, 2020
@wwilsman wwilsman deleted the ww/unpin-puppeteer branch June 2, 2020 16:16
djones pushed a commit that referenced this pull request Jun 2, 2020
## [0.26.9](v0.26.8...v0.26.9) (2020-06-02)

### Bug Fixes

* **📦:** Unpin puppeteer ([#522](#522)) ([e196d3d](e196d3d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants