Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unhide start and stop commands #534

Merged
merged 2 commits into from
Jul 10, 2020
Merged

feat: Unhide start and stop commands #534

merged 2 commits into from
Jul 10, 2020

Conversation

Robdel12
Copy link
Contributor

These shouldn't be hidden, they're useful and recommended to use in specific cases.

@Robdel12 Robdel12 requested a review from wwilsman July 10, 2020 20:31
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands extend from PercyCommand, which sets the hidden property to true. The property within these two commands is actually redundant, but need to be explicitly set to false now to unhide.

These shouldn't be hidden, they're useful and recommended to use in specifc
cases.
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 merged commit 7914a74 into master Jul 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the rd/unhide-start-stop branch July 10, 2020 21:22
djones pushed a commit that referenced this pull request Jul 10, 2020
# [0.27.0](v0.26.9...v0.27.0) (2020-07-10)

### Features

* Unhide `start` and `stop` commands ([#534](#534)) ([7914a74](7914a74))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants