🐛 Increase timeout to 1.5x the asset discovery timeout (30s) #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets that take a long time to respond in asset discovery can cause the `cy.then` promise to timeout. We _must_ wait for all assets to be discovered/resolved/captured before moving onto the next test, or we risk capturing the wrong asset for that given snapshot. For example, if the server shuts down after each test, we would fail to capture those assets if we didn't await on asset discovery to finish. With that said, we can safely increase this timeout beyond asset discoveries timeout since asset discovery will timeout first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Assets that take a long time to respond in asset discovery can cause the
cy.thenpromise to timeout. We must wait for all assets to be discovered/resolved/captured before moving onto the next test, or we risk capturing the wrong asset for that given snapshot. For example, if the server shuts down after each test, we would fail to capture those assets if we didn't await on asset discovery to finish (resulting in broken snapshots).With that said, we can safely increase this timeout beyond asset discoveries timeout since asset discovery will timeout first.