adding support for percyThrowErrorOnFailure , by default it will be false #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prklm10
commented
Jun 12, 2024
index.js
Outdated
| @@ -73,6 +73,8 @@ Cypress.Commands.add('percySnapshot', (name, options) => { | |||
| // Handle errors | |||
| log.error(`Could not take DOM snapshot "${name}"`); | |||
| log.error(error); | |||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
- I tried to write test to cover throwing of error, but was unable to do this.
- It is little complicated in cypress test to test this.
There was a problem hiding this comment.
issue -> cypress-io/cypress#2487. there is no definite answer here. Maybe we can sync on this.
prklm10
changed the title
ninadbstack
approved these changes
Jun 13, 2024
prklm10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for percyThrowErrorOnFailure, by default it will be false.
percyThrowErrorOnFailure is to be set in cypress config.