Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require the SDK utils directly from @percy/agent #53

Merged
merged 1 commit into from
Apr 6, 2019

Conversation

djones
Copy link
Contributor

@djones djones commented Apr 6, 2019

Require these SDK util functions directly to avoid having to include them in the main @percy/agent bundle which causes issues as it mixes code that should go into the browser vs code that should run in node.

Related issue: percy/percy-cypress#58

Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁🏁

@djones djones merged commit c258ce7 into master Apr 6, 2019
@djones djones deleted the david-jones/require-sdk-utils-directly branch April 6, 2019 22:36
djones pushed a commit that referenced this pull request Apr 6, 2019
## [1.0.2](v1.0.1...v1.0.2) (2019-04-06)

### Bug Fixes

* require sdk utils directly from @percy/agent ([#53](#53)) ([c258ce7](c258ce7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants