Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: require input to be parsed properly #378

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 14, 2020

Do not call saver if input is not in expected format (array).

Fixes ugly error given in response:

<br />
<b>Fatal error</b>:  Uncaught TypeError: Argument 1 passed to XHGui\Saver\MongoSaver::save() must be of the type array, null given, called in /var/www/xhgui/src/Xhgui/Controller/ImportController.php on line 57 and defined in /var/www/xhgui/src/Xhgui/Saver/MongoSaver.php:21
Stack trace:
#0 /var/www/xhgui/src/Xhgui/Controller/ImportController.php(57): XHGui\Saver\MongoSaver-&gt;save(NULL)
#1 /var/www/xhgui/src/Xhgui/Controller/ImportController.php(33): XHGui\Controller\ImportController-&gt;runImport(Object(Slim\Http\Request))
#2 /var/www/xhgui/src/routes.php(150): XHGui\Controller\ImportController-&gt;import(Object(Slim\Http\Request), Object(Slim\Http\Response))
#3 [internal function]: {closure}()
#4 /var/www/xhgui/vendor/slim/slim/Slim/Route.php(468): call_user_func_array(Object(Closure), Array)
#5 /var/www/xhgui/vendor/slim/slim/Slim/Slim.php(1355): Slim\Route-&gt;dispatch()
#6 /var/www/xhgui/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim-&gt;call()
#7 /var/www/xhgui/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middl in <b>/var/www/xhgui/src/Xhgui/Saver/MongoSaver.php</b> on line <b>21</b><br />

@glensc glensc added this to the Next milestone Dec 14, 2020
@glensc
Copy link
Contributor Author

glensc commented Dec 14, 2020

rebase after #379 merge

Do not call saver if input is not in expected format (array).
@glensc glensc merged commit f5c6a18 into master Dec 14, 2020
@glensc glensc deleted the import-validation branch December 14, 2020 18:08
glensc added a commit that referenced this pull request Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant