[Bug] usage of incorrect "set_error_handler" interface

[YuraLukashik]

It fails with the only error code.
http://php.net/manual/ru/function.set-error-handler.php

[codecov-io]

Current coverage is 96.73% (diff: 100%)

Merging #198 into master will decrease coverage by <.01%

@@             master       #198   diff @@
==========================================
  Files            20         20          
  Lines           645        644     -1   
  Methods         162        162          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            624        623     -1   
  Misses           21         21          
  Partials          0          0          

Powered by Codecov. Last update 2f5cdb1...6c1d8fa

[ezzatron]

Thanks for the PR! This should be fine to merge, and I'll try to include it in the next release.

So that I can include some extra tests, would you be able to paste the error handler code that you are using when this error occurs?

[YuraLukashik]

@ezzatron that began to happen after upgrade to Symfony 3. The handler is symfony debug error handler https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Debug/ErrorHandler.php#L368 and i think they updated it's interface.

[YuraLukashik]

[YuraLukashik]

@ezzatron it seems that i just had no errors before :)

[YuraLukashik]

this bug is reproducible only in php < 7, because php 7.* has Throwable interface which catches such errors.

[YuraLukashik]

@ezzatron added test, but it's for specific php versions.

[ezzatron]

@YuraLukashik Thanks, that helps a lot!

[ezzatron]

@YuraLukashik After looking through Symfony 3's error handler, it seems like they're using even more arguments than the 5 standard ones. I think, based upon that, it's probably wise just to pass on ALL arguments received by the handler. This way we are as transparent as possible.

I've created a branch with your commits plus some changes and more tests on the error-handler-signature branch. If you'd like to try this branch, you can do so using this version constraint:

{
    "peridot-php/peridot": "dev-error-handler-signature"
}

Is there any chance you could try this branch and let me know if you have any further issues?

Also, just wondering about this statement:

this bug is reproducible only in php < 7, because php 7.* has Throwable interface which catches such errors.

It seems to me like this has nothing to do with PHP 7, but if I'm missing something, perhaps you could explain this a bit more? In any case, I was able to remove the version restrictions from the spec you wrote, and with some minor adjustments, it passes just fine in all versions of PHP and HHVM.

[ezzatron]

Manually merged in 88d93d8.

[ezzatron]

@YuraLukashik This PR is scheduled for release at the end of this week, if you have any more comments or questions, it would be good to address them before then. Cheers!

[ezzatron]

Released in 1.19.0 🎉

[YuraLukashik]

@ezzatron thank you! 🎉