Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved stack trace output #203

Merged
merged 1 commit into from
Jan 6, 2017
Merged

Improved stack trace output #203

merged 1 commit into from
Jan 6, 2017

Conversation

ezzatron
Copy link
Contributor

@ezzatron ezzatron commented Jan 6, 2017

This PR:

  • Tidies up stack trace output by trimming stack entries that are irrelevant to the user.
  • Adds the exception file and line number to the output, which was previously missing.
  • Improves the exceptions thrown by failing assert() calls, by setting their file and line number to the location of the assert() call, rather than the location of the ASSERT_CALLBACK handler throw statement.

Closes #170.

@codecov-io
Copy link

codecov-io commented Jan 6, 2017

Current coverage is 97.08% (diff: 100%)

Merging #203 into master will increase coverage by 0.13%

@@             master       #203   diff @@
==========================================
  Files            20         21     +1   
  Lines           690        721    +31   
  Methods         172        176     +4   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            669        700    +31   
  Misses           21         21          
  Partials          0          0          

Powered by Codecov. Last update 19c73bd...ec46daa

@ezzatron ezzatron merged commit a73acdb into master Jan 6, 2017
@ezzatron ezzatron deleted the short-traces branch January 6, 2017 11:49
@ezzatron ezzatron added this to the Next release milestone Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants