Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Healthcheck.Persistence suicide probe #283

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Simplify Healthcheck.Persistence suicide probe #283

merged 1 commit into from
Jul 12, 2024

Conversation

Arkatufus
Copy link
Contributor

As described in the spec document, the suicide probe will only check for persistence recovery.

Changes

  • Fixed persistence id. Instead of using an ever changing GUID, the probe will only use "Akka.HealthCheck.Probe" as an id.
  • Suicide probe only check for recovery success, it does not check for write operations
  • Remove unit tests that relates to write operations

Aaronontheweb
Aaronontheweb approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit deac018 into petabridge:dev Jul 12, 2024
6 checks passed
@Arkatufus Arkatufus deleted the Simplify-persistence-probe branch July 15, 2024 13:52
@Arkatufus Arkatufus mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb