Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels option #410

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Conversation

jabranr
Copy link
Contributor

@jabranr jabranr commented Sep 24, 2022

Resolves #409

@jabranr jabranr marked this pull request as ready for review September 24, 2022 00:16
@peter-evans
Copy link
Owner

Hi @jabranr

Thank you for this contribution!

For consistency, I would love if this feature could be implemented in same way that labels are handled in create-pull-request.

  • Use utils.getInputAsArray()
  • Use the same wording for the description.

@peter-evans
Copy link
Owner

Let me merge this to a feature branch so I can make some minor adjustments. Then I'll merge it to main with your contributions.

@peter-evans peter-evans changed the base branch from main to labels-input October 24, 2022 07:28
@peter-evans peter-evans merged commit 4857eda into peter-evans:labels-input Oct 24, 2022
@peter-evans
Copy link
Owner

Released as v2.2.0 / v2.

Note that I removed the functionality to remove all labels when no labels are specified because it's not backwards compatible behaviour. There could be users that apply labels to an issue and want to keep them when the issue is closed via this action. The labels input currently allows two modes, an empty string means "do nothing," and any content means "replace labels on the issue with the specified content."

Thank you!

@jabranr jabranr deleted the add-labels-option branch February 22, 2023 19:25
@jabranr
Copy link
Contributor Author

jabranr commented Feb 22, 2023

@peter-evans Thank you for picking it up and moving it forward. Apologies that I become quite busy so couldn't find time to return to this any sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels option
2 participants