Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightState.rgb(255,255,255) produces red light #17

Closed
esco opened this issue Dec 18, 2014 · 3 comments
Closed

lightState.rgb(255,255,255) produces red light #17

esco opened this issue Dec 18, 2014 · 3 comments

Comments

@esco
Copy link

esco commented Dec 18, 2014

Produces a red light after passing white rgb colors

lightState
.create()
.on()
.rgb(255,255,255)
.brightness(100)

Produces a white light after passing black rgb colors

lightState
.create()
.on()
.rgb(0, 0, 0)
.brightness(100)
@peter-murray
Copy link
Owner

I will take a look into this tonight, as it may be more practical to convert into the xy color space insterad of hsl values.

Incidentally, black is a meaningless color when it comes to hue bulbs, they cannot turn black, so white might make some sense there...

@peter-murray
Copy link
Owner

Can you try the latest version 0.2.5 of the module and see if that gives you better results?

In my testing it appears to give closer matches to the extremes and now uses a conversion from RGB to XY co-ordinates as documented for the iOS library, so should be about a good as I can get for now.

@esco
Copy link
Author

esco commented Dec 19, 2014

Awesome I'll test this out today

On Friday, December 19, 2014, Peter Murray [email protected] wrote:

Can you try the latest version 0.2.5 of the module and see if that gives
you better results?

In my testing it appears to give closer matches to the extremes and now
uses a conversion from RGB to XY co-ordinates as documented for the iOS
library, so should be about a good as I can get for now.


Reply to this email directly or view it on GitHub
#17 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants