ChoiceType array crash due to value name

[danWithAD]

I've run into this simultaneously in local and remote running instance of node-hue-api.

Error log is as follows,

Failed to get a remote connection using existing tokens.
ApiError: Value 'allreadytoinstall' is not one of the allowed values [unknown,noupdates,transferring,anyreadytoinstall,allreadtoinstall,installing]

I've temporarily fixed this by adding the following to node_modules/node-hue-api/lib/types/ChoiceType.js

  _convertToType(val) {
    if (this.validValues.indexOf(val) > -1 || val === 'allreadytoinstall') {
      return val;
    } else {
      throw new ApiError(`Value '${val}' is not one of the allowed values [${this.validValues}]`);
    }
  }

[peter-murray]

It appears that hue has added another value to this choice type,

node-hue-api/lib/model/BridgeConfiguration.js

Line 31 in 80a6e44

validValues: [

I will modify the values and give you a pre release to test with later today.

[danWithAD]

Thank you so much!

[peter-murray]

This has been fixed in 5.0.0-alpha.2 which is in the npm registry (or at least it has in my local testing).

Due to this being a fix that will be required in the 4.x releases, I have just released this change in 4.0.6 as well.

@danWithAD please verify when you get a chance

[danWithAD]

@peter-murray I can confirm that in both local and prod pulling the latest version from master repo works!

[dtsn]

@peter-murray did you patch 4.0.6? Just forced an update on 4.0.6 and I don't get the change. Looking at the tag in github it appears to be missing https://github.com/peter-murray/node-hue-api/blob/v4.0.6/lib/model/BridgeConfiguration.js#L36

[peter-murray]

@dtsn Sorry about that, looks like I failed to apply the actual commit for the fix and just cherry-picked two other commits that referenced it 🤦

I have released 4.0.7 with the correct fix in it now, please try pulling that version from the npm registry.

[dtsn]

@peter-murray Works great! Thanks.