Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-build-isolation feature #311

Merged
merged 1 commit into from
Mar 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pipcompilemulti/features/controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from .skip_constraint_comments import SkipConstraintComments
from .live_output import LiveOutput
from .extra_index_url import ExtraIndexUrl
from .no_build_isolation import NoBuildIsolation


class FeaturesController:
Expand All @@ -44,6 +45,7 @@ def __init__(self):
self.skip_constraint_comments = SkipConstraintComments()
self.live_output = LiveOutput()
self.extra_index_url = ExtraIndexUrl()
self.no_build_isolation = NoBuildIsolation()
self._features = [
self.annotate_index,
self.use_cache,
Expand All @@ -63,6 +65,7 @@ def __init__(self):
self.skip_constraint_comments,
self.live_output,
self.extra_index_url,
self.no_build_isolation,
]

def bind(self, command):
Expand Down
21 changes: 21 additions & 0 deletions pipcompilemulti/features/no_build_isolation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from .base import ClickOption
from .forward import ForwardOption


class NoBuildIsolation(ForwardOption):
"""
Enable isolation when building a modern source distribution.
Build dependencies specified by PEP 518 must be already installed if build isolation is disabled.
"""

OPTION_NAME = 'no_build_isolation'
CLICK_OPTION = ClickOption(
long_option='--no-build-isolation',
is_flag=True,
default=False,
help_text=(
'Enable isolation when building a modern source distribution. '
'Build dependencies specified by PEP 518 must be already installed if build isolation is disabled.'
),
)
enabled_pin_options = ['--no-build-isolation']
2 changes: 1 addition & 1 deletion tests/test_cli_v1.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def requirements_dir():


@pytest.mark.parametrize('command', ['--no-upgrade', '--upgrade',
'--upgrade-package=pip-tools'])
'--upgrade-package=pip-tools', '--no-build-isolation'])
def test_v1_command_exits_with_zero(command):
"""Run pip-compile-multi on self.

Expand Down