Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate imports when generating matchers of map types #106

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Avoid duplicate imports when generating matchers of map types #106

merged 1 commit into from
Jul 8, 2020

Conversation

oceanful
Copy link

@oceanful oceanful commented Jul 7, 2020

Fixes #105

@petergtz
Copy link
Owner

petergtz commented Jul 8, 2020

Super cool! Thank you, @oceanful. One last thing before I can merge this: could you please change this PR to go against develop instead of master? I will try to merge it to master soon and make a new release.

Thank you,
Peter

@oceanful oceanful changed the base branch from master to develop July 8, 2020 21:45
@oceanful
Copy link
Author

oceanful commented Jul 8, 2020

Thanks @petergtz! Done!

@petergtz petergtz merged commit 97f0a7e into petergtz:develop Jul 8, 2020
@petergtz petergtz mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate imports in matcher of map type with key and value in the same package
2 participants
@oceanful @petergtz