DroidFIsh update with upstream commits made and compiled successfully on the branch I forked #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, It would be useful for new players to show the squares that the piece can go when a piece is touched. Thanks. |
|
Hi @Duy-Thanh Thanks for the updating work! Which version of NDK are you using? I am still struggling to build, I have tried various ndk-build versions but there are always errors and I cannot get the CuckooChess.jar and CuckooChessEngine.jar and the build can't continue... |
|
I successfully compiled these in Android Studio Bumblebee version and with the NDK that comes with that Android Studio version Sorry I haven't had time to check again to see if it still works with new versions later, I will update as soon as I check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Today I made some changes to this application on another branch that I forked, and today, I decided to contribute them upstream so that everyone will get the latest versions. Best update for this app. I will try to maintain and update it.
In this upstream commit, I added and modified the following:
All of the above has been compiled and run successfully with Android Studio Bumblebee Preview Version and running fine with Sony Xperia Z2 D6503, CPU: Snapdragon 801, 3GB RAM, Armeabi-v7a Architecture with NEON support, running on LineageOS 18.1( with the mainline version of the Stockfish engine on GitHub but with the condition that NNUE is disabled)
I have also updated the Stockfish engine to the mainline version (which can now be git cloned from on github) - (it needs fixing though as the engine crashes when I enable NNUE)
ATTENTION: Right now I still really can't figure out how to fix the engine terminated error when NNUE is enabled, anyone have any ideas? Any solution is highly appreciated.
(NOTE: In this upstream commit I will not commit the engine as it cannot be used with NNUE enabled. The old Stockfish engine that ships with the latest version of DroidFish as of now continues to be usable. use and run as well as compile normally)