updated all dependencies, removed fibers - now compiles and runs again #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Frank, thanks for the PR. I`ll review it now ... |
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
pharindoko
reviewed
Jan 8, 2023
| server, | ||
| new FileStorageAdapter('db.json'), | ||
| swagger, | ||
| true |
There was a problem hiding this comment.
that`s interesting why this can be true - I need to test and build this repo again to figure out why ...
pharindoko
requested changes
Jan 8, 2023
There was a problem hiding this comment.
thanks @fwornle - have checked your code, plz see my comments
Reverted to original, after PR review
Removed debug comment
|
thanks for the update @fwornle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review, if this is useful - with these changes, I managed to build and deploy the backend and build and run the frontend (locally) - sign-up and login via Cognito appears to work as expected, but the Vue App does not display the data from the backend (API calls refuse connection).
As I have never worked with Vue and currently do not have the time to dig deeper, I leave it here... maybe a useful starting point for others who still want to use this (without the update of the dependencies + removal of fibers it did not compile/build/run on my [Windows] machine).