This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Support evenement 2.0 and 3.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @elazar @svpernova09 is there anything blocking this from getting merged (and preferably released)? |
|
@WyriHaximus Is there anything we can do to fix the build failures? |
|
@elazar I can look into those, but they seem unrelated to this PR so I'll be filing a new one |
WyriHaximus
force-pushed
the
evenement-3.0-and-2.0
branch
from
4c723e7 to
0223ee0
Compare
|
Rebased and squashed |
|
👍 |
|
Thanks! |
|
Awesome 🎉 . Any chance for a tag soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evenement 3.0 has 99.9% the same API as 2.0 and provides a contains a nice performance improvement. I didn't see any cases where it would cause issues with Phergie so it should be good to go 🎉