Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Alias timer interface for event-loop 0.4 and 0.5 compatibility #68

Merged
merged 2 commits into from
Jul 27, 2018

Conversation

WyriHaximus
Copy link
Member

In react/event-loop 0.5 we moved the TimerInterface in reactphp/event-loop#138. This PR adds a compatibility file to make sure this package keeps working with event-loop 0.4 and 0.5.

@WyriHaximus
Copy link
Member Author

@elazar as discussed updated this PR to drop react/event-loop 0.4 support

@elazar
Copy link
Member

elazar commented Jun 24, 2018

Looks good to me. We'll need to document that Client->isTimerActive() has been removed when these changes are released. Since this is technically a major API change, I'd assume it would require a major version bump.

@svpernova09 svpernova09 merged commit 7a05fd0 into phergie:master Jul 27, 2018
@WyriHaximus
Copy link
Member Author

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants