Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODAP wrapper: Environment should be save/loadable in CODAP file #232

Closed
matthew-blackman opened this issue Mar 6, 2024 · 5 comments
Closed

Comments

@matthew-blackman
Copy link
Contributor

matthew-blackman commented Mar 6, 2024

Note: We would also like to save/load the simulation state if possible.

@samreid
Copy link
Member

samreid commented Mar 8, 2024

@samreid
Copy link
Member

samreid commented Mar 11, 2024

There is a project at https://github.com/concord-consortium/codap-plugin-api that looks like it provides support for saving/loading the state and configuration. I looked to see if we could adapt its pattern in our existing wrapper, but it was unclear. We could try porting our wrapper to use that plugin-api and see if it helps.

@samreid
Copy link
Member

samreid commented Mar 11, 2024

I tried building and adding references to the codap-plugin-api and ran into several problems:

  • The built files are *.js but they reference each other without suffixes. I went through and added suffixes
  • The iframe-phone uses require but the codap-plugin-api uses import

Could not get things working and I'm not sure whether this is a good idea.

@samreid samreid removed their assignment Apr 1, 2024
@samreid samreid removed their assignment Apr 5, 2024
@samreid
Copy link
Member

samreid commented Apr 24, 2024

@matthew-blackman and I got this working yesterday. I improved the state handling logic and committed a working version. This should be reviewed and tested, and we will need to know whether to implement this for the tool data wrapper as well.

@samreid samreid added status:ready-for-review and removed dev:help-wanted Extra attention is needed labels Apr 24, 2024
@matthew-blackman matthew-blackman changed the title CODAP wrapper: Checkbox states for streaming data should be save/loadable in CODAP file CODAP wrapper: Environment should be save/loadable in CODAP file Apr 24, 2024
@matthew-blackman
Copy link
Contributor Author

@catherinecarter @samreid and I reviewed this and everything is working well in our testing. The save/load, copy and 'shared view' features are all supported by the wrapper. This includes the simulation state, the checkboxes and the CODAP data. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants