Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update version of crates #1031

Merged
merged 2 commits into from
Aug 7, 2021
Merged

Conversation

Foo-x
Copy link
Contributor

@Foo-x Foo-x commented Jun 30, 2021

Closes #1030

Applied #990 to the other languages.

@phil-opp
Copy link
Owner

Thanks a lot! I think that the update requires some more changes, e.g. changing &mut InterruptStackFrame to InterruptStackFrame. I think this mainly affects the Japanese and Persian translations (cc @hamidrezakp @MHBahrampour @woodyzootopia @JohnTitor).

Replace `&mut InterruptStackFrame` to `InterruptStackFrame` due to the version updating.

Closes phil-opp#1030
@Foo-x
Copy link
Contributor Author

Foo-x commented Jun 30, 2021

Thanks to your review!
I checked it, and it didn't work without the changes as you said.
Fixed.

@hamidrezakp
Copy link
Contributor

Thanks a lot! I think that the update requires some more changes, e.g. changing &mut InterruptStackFrame to InterruptStackFrame. I think this mainly affects the Japanese and Persian translations (cc @hamidrezakp @MHBahrampour @woodyzootopia @JohnTitor).

I think there is no problem with Persian translation after this commit.
Did you mean the problem with Right-to-left?

Copy link
Contributor

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be great if we could also update translation_based_on_commit but otherwise this applies the same changes as #990, LGTM.

@phil-opp phil-opp merged commit d8eff6b into phil-opp:main Aug 7, 2021
@phil-opp
Copy link
Owner

phil-opp commented Aug 7, 2021

Thanks everyone!

@Foo-x Foo-x deleted the 1030-update-versions branch August 7, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply #990 to the other languages
4 participants