Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmf.SimpleTindexSnowMelt() does not scale to Cell.area #2

Closed
kbstn opened this issue Dec 11, 2017 · 3 comments
Closed

cmf.SimpleTindexSnowMelt() does not scale to Cell.area #2

kbstn opened this issue Dec 11, 2017 · 3 comments
Assignees
@philippkraft

Comments

@kbstn
Copy link
Contributor

kbstn commented Dec 11, 2017

With increasing size of my cmf.project.cell.area my CVodeIntegrator rises Error.

I could trace it back to the cmf.SimpleTindexSnowMelt() function. Itr seems like its not scaling properly to the cell size.
philippkraft referenced this issue Dec 11, 2017
@philippkraft
Limited melt rate in SimpleTindexSnowMelt tothe current volume per 10…
bada989 
… min to address issue #1
@philippkraft philippkraft self-assigned this Dec 11, 2017
@philippkraft
Copy link
Owner

Should work with this version, @kbstn can you check and confirm the solution?

@kbstn
Copy link
Contributor Author

kbstn commented Dec 11, 2017

thanks for the fast response, i checked and unfortunately the fix does not solve my issue.

philippkraft added a commit that referenced this issue Dec 12, 2017
@philippkraft
Added a scale parameter to state variable (default=1) to scale absolu…
4ed21fe 
…te tolerances. Another take on #2.
@kbstn
Copy link
Contributor Author

kbstn commented Dec 12, 2017

Works now. Slight scale dependency for computation time is still there, but main issue is solved.

@kbstn kbstn closed this as completed Dec 12, 2017
@philippkraft philippkraft mentioned this issue Dec 20, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippkraft philippkraft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbstn @philippkraft