#684 Relative Symlinks #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on Symfony/Filesystem->makePathRelative()
dwkitchen
commented
Mar 3, 2017
| @@ -236,7 +236,36 @@ protected function getMap() | |||
| } | |||
|
|
|||
| if ($this->isRelative()) { | |||
| $fromDir = $fs->getDir($this->getProject())->getPath(); | |||
| $endPath = $fs->getDir($this->getProject())->getAbsolutePath(); | |||
| $startPath = $this->getLink(); | |||
There was a problem hiding this comment.
This only works if the link path given is absolute, how to get absolute path from $this->getLink()?
There was a problem hiding this comment.
You can get the absolute path for $this->getLink() in combination with PhingFile like:
$startPath = (new PhingFile($this->getLink()))->getAbsolutePath();
There was a problem hiding this comment.
@siad007 Thanks for that updated and working with a relative path to the project root is given in the command.
Get the absolute path for the link using PhingFile
ghost
mentioned this pull request
Merged
Closed
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closed in favor of #695 - thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Symfony/Filesystem->makePathRelative()