Add 256 filename support (prefix + name) and add support for space terminated numbers and non-null terminated names #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rminated numbers.
schnoberts1
force-pushed
the
add-support-for-non-null-terminated-strings-and-256-length-filenames
branch
from
5f4747c to
46770c5
Compare
schnoberts1
force-pushed
the
add-support-for-non-null-terminated-strings-and-256-length-filenames
branch
from
8e6bb88 to
29e3a28
Compare
phip1611
reviewed
Aug 31, 2023
|
I noticed a few of the checks failed. The Linux ones just cancelled, the windows one fails to check out the repo due to: Error: error: unable to create file tests/01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234/ABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJABCDEFGHIJ: Filename too long I can remove this and simply leave the test tar file if you like. |
…rmally these aren't needed as the .tar files are used in the source. The tests themselves note what files they depend on.
…grading them past the Rust 1.60 compiler. Example from an indirectly dependent crate on Linux: error: package `rustix v0.38.11` cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.60.0
|
Hi! Sorry, I'm kind of busy. I hope, I can look on this soon. |
|
No worries. I’m just working off my fork anyway. On 11 Sep 2023, at 02:47, Philipp Schuster ***@***.***> wrote:
Hi! Sorry, I'm kind-off busy. I hope, I can look on this soon.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Thank you so much for your contribution, @schnoberts1. Sorry, I totally forgot about it. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as discussed previously. As before, maybe this isn't idiomatic. Also, I'm not sure I like how I've done the loop to skip over directories. I wonder if it would be better to skip over everything but regular files. It'd make the logic easier and if the assumption that all tar headers have correct size fields is true it would mean we skip things we don't care about rather than stop. That being said, perhaps that is undesirable as in your code we know that we can't parse the tar file completely.
Very much a first cut and looking for opinions.