Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify SDK projects by import statements #1

Closed
daveaglick opened this issue Sep 27, 2017 · 0 comments
Closed

Identify SDK projects by import statements #1

daveaglick opened this issue Sep 27, 2017 · 0 comments

Comments

@daveaglick
Copy link
Collaborator

daveaglick commented Sep 27, 2017 •
edited
Loading

Turns out you can also identify SDK projects via imports and there may not be a root SDK attribute:
dotnet/msbuild#1493

Right now we just look for the SDK attribute on the root element in the project file. Add support for locating SDK import elements if the SDK attribute isn't found.
bjorkstromm added a commit to bjorkstromm/Buildalyzer that referenced this issue Oct 9, 2017
@bjorkstromm
(phmonteGH-1) Adds failing tests.
109d4ad
bjorkstromm added a commit to bjorkstromm/Buildalyzer that referenced this issue Oct 9, 2017
@bjorkstromm
(phmonteGH-1) Identify SDK project based on import statement.
42e6218 
- Fixes phmonte#1
@bjorkstromm bjorkstromm mentioned this issue Oct 9, 2017
Closed
daveaglick pushed a commit that referenced this issue Oct 10, 2017
@bjorkstromm @daveaglick
(GH-1) Adds failing tests.
a67027b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daveaglick