Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_checks_compute() bugfix #837

Merged
merged 3 commits into from
Mar 28, 2024
Merged

run_checks_compute() bugfix #837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81763ab
run_checks_compute() bugfix
aprsa Mar 28, 2024
fda6a2b
Incorporating @kecnry's comments into the PR (along with additional c…
aprsa Mar 28, 2024
6fc6cb4
Fixing the if statement per @kecnry's instructions.
aprsa Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions phoebe/frontend/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3765,7 +3765,7 @@ def run_checks_compute(self, compute=None, solver=None, solution=None, figure=No

pb_needs_Inorm = True
pb_needs_Imu = True
pb_needs_ld = True #np.any([p.get_value()!='interp' for p in self.filter(qualifier='ld_mode', dataset=pbparam.dataset, context='dataset', **_skip_filter_checks).to_list()])
pb_needs_ld = True
pb_needs_ldint = True

missing_pb_content = []
Expand All @@ -3780,8 +3780,10 @@ def run_checks_compute(self, compute=None, solver=None, solution=None, figure=No
True, 'run_compute')

# NOTE: atms are not attached to datasets, but per-compute and per-component
for atmparam in self.filter(qualifier='atm', kind='phoebe', compute=computes, **_skip_filter_checks).to_list() + self.filter(qualifier='ld_coeffs_source').to_list():

# NOTE: atmparam includes a '_default' compute pset, which depends on the
# ck2004 atmospheres; the checks should not include it. This is achieved
# by filtering check_visible=False and check_default=True in the line below:
for atmparam in self.filter(qualifier='atm', kind='phoebe', compute=computes, check_visible=False, check_default=True).to_list() + self.filter(qualifier='ld_coeffs_source').to_list():
# check to make sure passband supports the selected atm
atm = atmparam.get_value(**_skip_filter_checks)
if atmparam.qualifier == 'ld_coeffs_source' and atm == 'auto':
Expand Down
Loading