Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default .gitignore to the init-app #132

Closed
thinkh opened this issue Dec 15, 2017 · 5 comments
Closed

Add default .gitignore to the init-app #132

thinkh opened this issue Dec 15, 2017 · 5 comments
Labels
type: bug Something isn't working

Comments

@thinkh
Copy link
Contributor

thinkh commented Dec 15, 2017

No description provided.

@sgratzl
Copy link
Contributor

sgratzl commented Dec 15, 2017

init-app is based on _init_web thus should have a .gitignore included

@sgratzl
Copy link
Contributor

sgratzl commented Dec 22, 2017

cannot reproduce:
greenshot_2017-12-22_14-08-35

@sgratzl sgratzl added status: invalid type: bug Something isn't working and removed Type: Feature labels Dec 22, 2017
@sgratzl sgratzl closed this as completed Dec 22, 2017
@NMO13
Copy link

NMO13 commented Dec 22, 2017

Also in my case, when doing yo phovea:init-app-slib, no .gitignore gets created.

image

@NMO13
Copy link

NMO13 commented Dec 22, 2017

Is it possible that the .gitignore file get created at the wrong place?
Here I have one:
image

But here (where .git is) I haven't:

image

@thinkh thinkh reopened this Dec 22, 2017
sgratzl added a commit that referenced this issue Dec 27, 2017
@sgratzl
#132 rename .gitignore to _gitignore with dedicated copying
dfb8f4c
@sgratzl
Copy link
Contributor

sgratzl commented Dec 27, 2017

reason: npm/npm#1862

@sgratzl sgratzl closed this as completed Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NMO13 @sgratzl @thinkh